feat: deflake TestEthFeeHistory #10816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridrik01
reviewed
May 4, 2023
arajasek
force-pushed
the
asr/deflake-ethhistory
branch
from
e3a674f
to
b6b3998
Compare
arajasek
commented
May 4, 2023
| require.NoError(err) | ||
|
|
||
| // Save the full view of the tipsets to calculate the answer when there are null rounds | ||
| tsHeights := []int{1} |
There was a problem hiding this comment.
Note: removing this line is the actual deflaking fix
raulk
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This test has been observed to flake, eg. here.
This particular failure arose because the test as currently written always expects the oldest non-genesis height to be 1. It IS possible for the first round to be null, though, which is what happened in the failure linked above.
Proposed Changes
Construct the heights based on the actual chain, not by hard-coding a first height of 1 and then observing chain head changes.
Happily, I was able to reproduce the flake by forcing the first tipset to be null, and confirmed that the change made here fixes the failure.
Additional Info
It would not surprise me if this test continues to flake for other reasons, but I am confident in this improvement.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps