feat: chainstore: exit early in MaybeTakeHeavierTipset #10839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
I've noticed multiple test failures* resulting from the observer system getting confused because it's asked to "apply" the same tipset as its current head. I'm not entirely sure why this happens, and I'm pretty sure there's an underlying issue (because the tipset question later can't be found in the blockstore for some reason).
BUT, regardless, we can just shortcut if we're ever asked to
MaybeTakeHeavierTipset
, which looks possible given that sync workers as well asSyncSubmitBlock
can lead here.*example 1, example 2, example 3
Proposed Changes
Exit early.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps