feat: deflake paych_api_test #10843
Merged
feat: deflake paych_api_test #10843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
May 8, 2023
itests/paych_api_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| // it doesn't matter which node we "wait" on | ||
| paymentReceiver.WaitTillChain(ctx, kit.HeightAtLeast(head.Height()+policy.PaychSettleDelay+5)) |
There was a problem hiding this comment.
Making sure that all nodes are at that height? Probably would be best to do as a helper, kit.WaitTillChainAll.. or something like that
There was a problem hiding this comment.
@ZenGround0 Just a little extra buffer, not needed
@magik6k Yeah, good suggestion, will do
arajasek
force-pushed
the
asr/deflake-paych
branch
from
46974e1
to
c6fb2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This test has been observed to flake a lot, example https://app.circleci.com/pipelines/github/filecoin-project/lotus/28643/workflows/32a2f145-5cac-492b-a00e-3ce566d50691/jobs/965295.
The problem is that we try to inject a lot of nulls in order to fast-forward the Paych Settle Delay (which is 12 hours on mainnet). This is nice to speed up the test, but just leads to missed PoSts, especially because we fast-forward entire deadlines at a time.
Proposed Changes
Just wait for the PaychSettleDelay to "normally" pass -- this is only 14 seconds, we don't need to risk flakiness. We could consider skipping fewer epochs at a time, but I honestly don't think it's worth it.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps