feat: deflake sector_import_simple #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
May 11, 2023
magik6k
reviewed
May 12, 2023
| client, miner, ens := kit.EnsembleMinimal(t, kit.ThroughRPC()) | ||
| // We use two miners so that in case the actively tested miner misses PoSt, we still have a blockchain | ||
| client, miner, _, ens := kit.EnsembleOneTwo(t, kit.ThroughRPC()) | ||
|
|
||
| ens.InterconnectAll().BeginMining(blockTime) |
There was a problem hiding this comment.
Actually in this case BeginMiningMustPoSt should help. What I think may be happening here is that we are trying to produce the post snark, but that is blocked while the sector is Committing - in which case EnsembleOneTwo may still not be robust enough, because Committing even for 2k sectors takes a few seconds, and takes the global gpu lock, which will prevent any post from being created
There was a problem hiding this comment.
We've had pretty good luck since we turned the other test to use 2 miners. I'm gonna merge this for now, but will definitely try MustPosting if the issue recurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This test has been observed to flake, eg. here, due to missed PoSts.
Proposed Changes
Use 2 miners instead of one for this test. We made the identical change to sector_import_full_test.go in #10764, and it hasn't flaked once since then (afaic tell).
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps