fix: pubsub: do not treat ErrExistingNonce as Reject #10973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This might help with #10906.
The
ErrExistingNonce
error is thrown when we already have the exact message we're trying to add in our pending mset. It is an error to try and add this message, but it is not wrong for us to receive a message multiple times, and try to add it. We should definitely not penalize peers who inform us of messages we've already added.What's not clear to me is whether something earlier in the pipeline should be realizing that we've already processed this message. Regardless, however, I think we should be treating this case as an Ignore, not a Reject.
Proposed Changes
Lower the pubsub handling of this particular failure to Ignore.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps