feat: deflake TestDealsWithFinalizeEarly #10978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
previously approved these changes
Jun 13, 2023
|
Looks like the issue lies elsewhere... |
arajasek
force-pushed
the
asr/deflake-finalize-early
branch
from
f540629 to
44aadb7
Compare
|
Ah, it's cause only one miner can be "compelled" to PoSt. Fixed up. |
Stebalien
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This test has been observed to flake, eg https://app.circleci.com/pipelines/github/filecoin-project/lotus/29148/workflows/9be15326-5b82-4c13-943b-f38e229bb37e/jobs/990528
The failure in the linked build is simply because a PoSt was never submitted for the miner
Proposed Changes
Use the
MustPostversion of mining loop for itestsAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps