feat:lotus-bench:AMT benchmarking #11075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
commented
Jul 13, 2023
| @@ -0,0 +1,309 @@ | |||
| package main | |||
|
|
|||
There was a problem hiding this comment.
This is just copy pasted from AMT package. Couldnt import because it is internal over there.
There was a problem hiding this comment.
Can you explain/link directly to the AMT package?
There was a problem hiding this comment.
There was a problem hiding this comment.
And this is just code for reading/writing from go memory structures to cbor bytes
There was a problem hiding this comment.
I think the rest of the code looks great, just this question: Does it make sense to add a comment to the top of the file with this link and maybe an explanation of why you are adding it to this repo instead of linking/import it?
ZenGround0
force-pushed
the
bench/amt-churn
branch
from
f388fe9
to
4d8f8d2
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11035
Proposed Changes
lotus-bench amtcreates an in memory amt and measures a breakdown of its size and node count between link and value nodes. It further measures the size of churn when overwriting a portion of the amt.Additional Info
This doesn't need any additional testing, I've used the tool enough to see that it generally works and its results make sense in the context of the problem I used it to solve.
If anyone cared to do so they could generalize the amt setup for different bitwidths and sizes. This was not valuable for the problem I was trying to solve so I have deferred doing this.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps