Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version minimum #11131

Closed
wants to merge 7 commits into from
Closed

update go version minimum #11131

wants to merge 7 commits into from

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Aug 3, 2023

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn changed the base branch from master to release/v1.23.3 August 8, 2023 21:13
@snissn snissn marked this pull request as ready for review August 8, 2023 22:22
@snissn snissn requested a review from a team as a code owner August 8, 2023 22:22
@snissn
Copy link
Contributor Author

snissn commented Aug 8, 2023

Please note that I had to remove the unsupported linter structcheck and we should use and support the latest linter - unused in additional work. I'm not exactly sure what is triggering the issue, but this PR which is the same but without the linter modification the linter check is failing - unfortu #11150

@snissn snissn marked this pull request as draft August 8, 2023 23:29
@snissn snissn closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant