Backport: feat: sealing: Switch to calling PreCommitSectorBatch2 #11215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
changed the title
jennijuju
reviewed
Aug 29, 2023
| requires: | ||
| - build | ||
| suite: itest-ccupgrade | ||
| target: "./itests/ccupgrade_test.go" |
There was a problem hiding this comment.
a bit surprised t see t tests being removed 👁️
There was a problem hiding this comment.
This is the extremely old replace-sector-with-another-sector CC upgrade, not snapdeals.
It's not even supported in actors anymore
jennijuju
reviewed
Aug 29, 2023
| @@ -107,7 +108,10 @@ func (mgr *SectorCommittedManager) OnDealSectorPreCommitted(ctx context.Context, | |||
|
|
|||
| // Watch for a pre-commit message to the provider. | |||
| matchEvent := func(msg *types.Message) (bool, error) { | |||
| matched := msg.To == provider && (msg.Method == builtin.MethodsMiner.PreCommitSector || msg.Method == builtin.MethodsMiner.PreCommitSectorBatch || msg.Method == builtin.MethodsMiner.ProveReplicaUpdates) | |||
| matched := msg.To == provider && (msg.Method == builtin.MethodsMiner.PreCommitSector || | |||
| msg.Method == builtin.MethodsMiner.PreCommitSectorBatch || | |||
There was a problem hiding this comment.
out of curiosity - any reason why we wanna keep PrecommitsectorBatch?
There was a problem hiding this comment.
Sectors still can be onboarded with the old precommit, and this helper may still be pulled by e.g. by boost, so we probably want to keep support for the old method at least until the next network version.
I don't think there's much harm in keeping old stuff here, the whole markets/ package will go anyways as we deprecate legacy markets.
ZenGround0
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This PR backports #11142 to feat/nv21
Related to #11125
Proposed Changes
Additional Info
This is required because nv21 will remove the old Precommit methods. DDO also requires the use of the new methods, so any integration work must be on top of this code
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps