Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release: Set calibration upgrade height #11331

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore: release: Set calibration upgrade height #11331

merged 2 commits into from
Oct 12, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 12, 2023 •
edited
Loading

Proposed Changes

Set the calibration upgrade height to epoch 1013134. Which should be equal to:

  • 13:00 UTC on October 19th, 2023
    • 6:00 AM in Los Angeles - 2:00 PM in London - 9:00 PM in Beijing

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@rjan90
chore: build: set calibration upgrade height
5fa44b1 
chore: build: set calibration upgrade height
@rjan90 rjan90 requested a review from a team as a code owner October 12, 2023 20:47
arajasek
arajasek reviewed Oct 12, 2023
View reviewed changes
build/params_calibnet.go Outdated
// ??????????
const UpgradeWatermelonHeight = 999999999999999
// 2023-10-19T13:00:00Z
const UpgradeWatermelonHeight = 1013200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the time here is exactly right? It's 2023-10-19T13:33:00Z, I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1013134 would be 2023-10-19T13:00:00Z)

Copy link
Contributor

@arajasek arajasek Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to update to 1013134 for now and merge -- we can change later if I'm wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, Epoch 1013134 would be 2023-10-19T13:00:00Z! Never trust ChatGPT when doing many follow-up questions about epochs I guess!

arajasek
arajasek approved these changes Oct 12, 2023
View reviewed changes
build/params_calibnet.go Outdated Show resolved Hide resolved
@arajasek arajasek merged commit 0e0b553 into feat/nv21 Oct 12, 2023
@arajasek arajasek deleted the feat/set-calibration-height branch October 12, 2023 23:23
@Fatman13 Fatman13 mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjan90 @arajasek