Simpleharmony #11358
Merged
Simpleharmony #11358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Oct 27, 2023
storage/wdpost/wdpost_task.go
Outdated
There was a problem hiding this comment.
I moved this file to provider/lpwindow/task.go (mostly to keep storage/wdpost free of changes which don't need to be there + to have an easier time extracting lotus-provider work to a separate repo if that ever needs to happen)
There was a problem hiding this comment.
(so if there are any changes here, they should be merged into provider/lpwindow/task.go, and this file shouldn't be committed)
magik6k
approved these changes
Oct 30, 2023
Comment on lines
79
to
+84
| Value: "~/.lotus/storage.json", | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "journal", | ||
| Usage: "path to journal files", | ||
| Value: "~/.lotus/", |
There was a problem hiding this comment.
.lotus is for the chain node, we want a separate dir for lotus-provider
There was a problem hiding this comment.
How did you manage to commit that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the harmonytask system compatible with WinningPost.
The simpler design means that the existing, (passing) unit tests now comprehensively cover the use-cases.