Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eth: use the correct state-tree when resolving addresses #11387

Merged
merged 4 commits into from
Nov 17, 2023
Merged

fix: eth: use the correct state-tree when resolving addresses #11387

merged 4 commits into from
Nov 17, 2023

Commits on Nov 17, 2023

  1. fix: eth: use the correct state-tree when resolving addresses 

    We need to always use the state-tree from the tipset _after_ the message
executed. If we use any other state-tree, we might not find the address
we're trying to resolve.

This change also has some implication for pending messages: there's no
guarantee we'll be able to generate a 0x-style address for a pending
native message. So, instead of trying, I've removed support for pending
native messages from the Eth API. Messages from EthAccounts will still
work, and native messages will still show up in blocks/traces, they just
won't show up as "pending". Which should affect exactly nobody.

I'm also taking this opportunity to cleanup some edge-cases:

1. Pass contexts where appropriate.
2. Remove all state access from `ethTxHashFromSignedMessage`.

Part of #11355
    @Stebalien
    Stebalien committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2253cd2 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @Stebalien
    Stebalien committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8e0dd4d View commit details
    Browse the repository at this point in the history

  3. fill in changelog

    @Stebalien
    Stebalien committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b1a4391 View commit details
    Browse the repository at this point in the history

  4. fix the changelog

    @Stebalien
    Stebalien committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c0c3614 View commit details
    Browse the repository at this point in the history