feat: lotus-provider: WinningPoSt support #11410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
commented
Nov 10, 2023
magik6k
force-pushed
the
feat/lp-winning
branch
from
9112693
to
8744312
Compare
mtrisic
reviewed
Nov 12, 2023
snadrus
approved these changes
Nov 14, 2023
| log.Warnw("mined block in the past", | ||
| "block-time", btime, "time", build.Clock.Now(), "difference", build.Clock.Since(btime)) | ||
| } | ||
|
|
||
| // Check for slash filter conditions. | ||
| if os.Getenv("LOTUS_MINER_NO_SLASHFILTER") != "_yes_i_know_i_can_and_probably_will_lose_all_my_fil_and_power_" && !build.IsNearUpgrade(base.TipSet.Height(), build.UpgradeWatermelonFixHeight) { |
There was a problem hiding this comment.
Should this os.GetEnv() be replaced with a config in the database?
There was a problem hiding this comment.
No, this is an extremely dangerous only-for-testing flag, doesn’t belong in user config
snadrus
reviewed
Nov 14, 2023
| @@ -161,7 +175,7 @@ environment variable LOTUS_WORKER_WINDOWPOST. | |||
| } | |||
|
|
|||
| if !lo.Contains(titles, "base") { | |||
| _, err = db.Exec(ctx, "INSERT INTO harmony_config (title, config) VALUES ('base', '')", "base") | |||
| _, err = db.Exec(ctx, "INSERT INTO harmony_config (title, config) VALUES ('base', '')") | |||
There was a problem hiding this comment.
We probably should have the migrator enable:
lpCfg.Subsystems.EnableWinningPost = true
And add a comment about diabling it in lotus-miner
|
Orjan mentioned: "null-blocks and a couple of other blockchain edge-cases". Be sure that's covered before merging since feat/sturdypost is planned for 1.25.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #11392
Closes #11383
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps