-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for lotus-provider, and conveniences #11419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits / Qs
cmd/lotus-provider/proving.go
Outdated
}, | ||
} | ||
|
||
var provingComputeWindowPoStCmd = &cli.Command{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to have a way to submit a mock-compute task to the database, so the computation isn't done in the local cli, but on the real workers (which imo is what SPs will expect in most cases - running check tasks on the cluster with proper scheduling, but no submitting things to the chain)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense. Would you want it to do that with live updates, or just direct them to logs and database to evaluate the success?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have either this or a separate command poll for success
It would be nice to add these to the default config, as they are needed for getting lotus-provider configured, but are currently missing from the basic config.toml:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more problems here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is objectively better, just two small things to fix
(also some conflicts) |
I'm going to propose a different CLI: lotus-provider test window-post task That is a bit clearer on what's going on with the two test commands, and provides an avenue for future integration test behavior. As a side-note, I also made it possible to have titled sql files since I was starting to get lost in all of them. I didn't persist the titles to the database because that seems pointless as it's a developer convenience that doesn't really have an analog at runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 think likely to fix, but this PR does make a lot of things better enough to merge now
Related Issues
FilOzone/Space-Panthers#11
Proposed Changes
Additional Info
For testing, these top-level commands (flags available):
lotus-provider test window-post here
Good for: CLI testing to ensure configuration layers & basic functionality work as expected.
Does not post to chain.
lotus-provider test window-post task
Good for: E2E testing of a lotus-provider that's enabled for the window-post task.
Does not post to chain.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps