Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lp api handler for stop #11473

Merged
merged 1 commit into from
Dec 3, 2023
Merged

fix: lp api handler for stop #11473

merged 1 commit into from
Dec 3, 2023

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Dec 3, 2023

Related Issues

Proposed Changes

implement an API handler like Worker does, but Provider-specific. Enable "stop" call for CLI to work.

Additional Info

I reused the endpoint shape that Common uses, so the client uses the Common API even though other funcs available to it will not work here.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from a team as a code owner December 3, 2023 06:41
@snadrus snadrus requested review from snissn and magik6k and removed request for a team December 3, 2023 06:41
@snadrus snadrus mentioned this pull request Dec 3, 2023
8 tasks
@@ -41,6 +41,12 @@ func PermissionedWorkerAPI(a Worker) Worker {
return &out
}

func PermissionedAPI[T any](a T) T {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay generics exist now; We could drop the other ones now, but that's a separate PR, not now

@magik6k magik6k merged commit 839d005 into feat/sturdypost Dec 3, 2023
86 of 89 checks passed
@magik6k magik6k deleted the fixLpStop branch December 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants