perf: cli: avoid allocations with (*regexp.Regexp).MatchString

[Juneezee]

Related Issues

Proposed Changes

We should use (*regexp.Regexp).MatchString instead of (*regexp.Regexp).Match([]byte(...)) when matching string to avoid unnecessary []byte conversions and reduce allocations. A simple one-line change for free small performance improvement.

func BenchmarkMatch(b *testing.B) {
	for i := 0; i < b.N; i++ {
		if match := infoWithToken.Match([]byte("foo.bar.baz: Some token")); !match {
			b.Fail()
		}
	}
}

func BenchmarkMatchString(b *testing.B) {
	for i := 0; i < b.N; i++ {
		if match := infoWithToken.MatchString("foo.bar.baz: Some token"); !match {
			b.Fail()
		}
	}
}

Result:

goos: linux
goarch: amd64
pkg: github.com/filecoin-project/lotus/cli/util
cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
BenchmarkMatch-16          	 2077356	       692.3 ns/op	      24 B/op	       1 allocs/op
BenchmarkMatchString-16    	 2970835	       415.6 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/filecoin-project/lotus/cli/util	3.704s

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
  • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
• If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green

[magik6k]

Please read the contributing guide

Please refrain from submitting PRs to adapt existing code to subjective preferences. The changeset should contain functional or technical improvements/enhancements, bug fixes, new features, or some other clear material contribution. Simple stylistic changes are likely to be rejected in order to reduce code churn.

Minimize code churn. Modify only what is strictly necessary..

[Juneezee]

Please read the contributing guide

@magik6k This is an enhancement and not a subjective and stylistic change.