-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: events: Lotus API to consume events (smart contract + built-in Actor events) #11540
Closed
Closed
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
8db6e73
Bump version in master
rjan90 c9f1325
Make gen
rjan90 271a011
Merge pull request #11475 from filecoin-project/phi-bump-master-v
magik6k 538039f
fix sender
snadrus 956ac8a
Merge pull request #11480 from filecoin-project/lpSenderBug
magik6k 943c223
fix: lotus-provider: Fix winning PoSt
magik6k 2d75cc5
Merge pull request #11482 from filecoin-project/fix/lp-winning
snadrus 685934a
fix: sql Scan cannot write to an object
snadrus 91b0032
do not suggest the default layer
snadrus e0a8fe3
Merge pull request #11485 from filecoin-project/sqlGptHard
magik6k e570693
lp docsgen
snadrus 3d30ded
Actually show miner-addrs in info-log
rjan90 9dd9458
Merge pull request #11490 from filecoin-project/phi-fix-lp-info-log
snadrus 4b1445e
fix: lotus-provider: Wait for the correct taskID
magik6k 93fd408
lotus-provider: additional fixes to make recover work
magik6k bf5132e
more sender fixes
magik6k d32b8be
Merge pull request #11493 from filecoin-project/fix/lp-send-taskid-wait
snadrus efb4a09
harmony: Fix task reclaim on restart
magik6k cf8fed9
Merge pull request #11498 from filecoin-project/fix/harmony-reclaim
snadrus 0e49673
fix: db serialize txn - retry
snadrus 1e09e1e
detect unsafe code uses
snadrus 4ab92ca
Fix log output format in wdPostTaskCmd
rjan90 986f240
fix: exchange: allow up to 10k messages per block
Stebalien 88e90aa
fix lints
Stebalien 7f684ec
Merge pull request #11506 from filecoin-project/steb/fix-exchange-mes…
magik6k f2a4891
fix: exchange: explicitly cast the block message limit const (#11511)
Stebalien 4a5c241
bump version
jennijuju 9dca434
fix: lint
snadrus 68c1e56
Merge pull request #11504 from filecoin-project/lp-wdposttaskcmd-format
magik6k 89fabbb
Merge pull request #11488 from filecoin-project/lpdocsgen
magik6k 47477c0
Merge pull request #11486 from filecoin-project/lpMigrateNicer
magik6k 96353e6
exp backoff, short stack err
snadrus de38e77
tx-detector use atomic
snadrus c912f3b
Merge pull request #11501 from filecoin-project/serializationFix
snadrus 6faeaa7
update libp2p deps
aarshkshah1992 d75d7c7
Merge pull request #11522 from filecoin-project/feat/update-libp2p-deps
magik6k 17f6f4c
fix: eth: decode as actor creation iff "to" is the EAM (#11520)
Stebalien fac1d11
Merge pull request #11512 from filecoin-project/jen/253
rjan90 d21802f
first draft with historical API
aarshkshah1992 cfd57cb
changes to first draft
aarshkshah1992 f7a36f6
fix tests and docsgen
aarshkshah1992 9f671af
refactor event filter manager
aarshkshah1992 55ed4cd
susbcribe API first draft
aarshkshah1992 4a59c01
check error value of removing filter
aarshkshah1992 5a0c2bc
itests support the new API
aarshkshah1992 0bf15fa
fix nits
aarshkshah1992 874b8ca
test and lint
aarshkshah1992 f33e154
remove test in CI
aarshkshah1992 c67ed4b
docsgen
aarshkshah1992 4d72fda
revert sed change
aarshkshah1992 3ad99bf
Merge remote-tracking branch 'origin/feat/nv22' into feat/built-in-ac…
aarshkshah1992 462e061
revert change
aarshkshah1992 a5fb594
rebase
aarshkshah1992 db0d736
Merge remote-tracking branch 'origin/feat/nv22' into feat/built-in-ac…
aarshkshah1992 a9c8959
make gen
aarshkshah1992 7b6d763
test: DDO onboarding non-market verified data
rvagg b8f7520
docs and more tests
aarshkshah1992 b02338a
tests
aarshkshah1992 a4f89a7
Apply suggestions from code review
aarshkshah1992 147c47e
Apply suggestions from code review
aarshkshah1992 2a219e2
lint
aarshkshah1992 ff17d7f
TEMP: extract events
rvagg b54d111
Extract buildActorEventsFromMessages and separate event printing code
rvagg 3f2c3a3
solve actor resolution bug
aarshkshah1992 cc04504
Merge remote-tracking branch 'origin/feat/built-in-actor-events-api' …
aarshkshah1992 a694690
tests for events API
aarshkshah1992 f9c891b
lint
aarshkshah1992 b5fba58
Apply suggestions from code review
aarshkshah1992 4cfd4f0
Merge pull request #11603 from filecoin-project/rvagg/ddo-verified
aarshkshah1992 8e71abf
review
aarshkshah1992 3faac88
Merge remote-tracking branch 'origin/feat/nv22' into feat/built-in-ac…
rvagg e500393
Clean up DDO+Events tests, add lots of explainer comments
rvagg 1744741
Minor tweaks to events types
rvagg 1bd7257
Merge pull request #11613 from filecoin-project/rvagg/actor-events-tweak
aarshkshah1992 1880835
make gen
aarshkshah1992 55784cf
Merge remote-tracking branch 'origin/feat/nv22' into feat/built-in-ac…
rvagg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this is a great API; It feels really clunky to have to specify the codec here, which is encouraged by the clunky nature of the events themselves of course (!).
We do have the option of leaving the Codec off and just keeping it
map[string][][]byte
and matching on that, the bytes are going to remain the same, identical to theValue
they provide here. It will lack the precision of saying "this value, which is this codec", but that's not too much different from just "this value".It's not like we're doing anything fancy with the
Codec
here of course—e.g. decoding theirValue
and re-encoding it to the codec specified by the event, theValue
is the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg
Yeah this is true. I think just a nice way for clients to ensure they're using the right codec as we use different ones for smart contract vs built-in Actor events so they're not left wondering why their filter isn't matching anything. I think best to keep it for now to make it explicit. We can remove this later once our experimental API gets some feedback.