-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker: Dockerfile import snapshot #11579
fix: docker: Dockerfile import snapshot #11579
Conversation
198862b
to
686bf7e
Compare
scripts/docker-lotus-entrypoint.sh
Outdated
GATE="$LOTUS_PATH"/date_initialized | ||
# Don't init if already initialized. | ||
if [ ! -f "$GATE" ]; then | ||
echo importing minimal snapshot | ||
/usr/local/bin/lotus daemon --import-snapshot "$DOCKER_LOTUS_IMPORT_SNAPSHOT" --halt-after-import | ||
printf 'yes\n' | /usr/local/bin/lotus daemon --import-snapshot "$DOCKER_LOTUS_IMPORT_SNAPSHOT" --halt-after-import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually seems like a bug. We should only be prompting the user if there's actually a chain to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on master, this change shouldn't be necessary anymore. Although it may help to pass --remove-existing-chain=false
(which will cause an immediate failure if there's an existing change, which there shouldn't be given that the node isn't initialized).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and added the flag. Although, I'm not sure what happened to the unreleased changelog.
@vidbregar can you rebase on master and address my comment? |
686bf7e
to
307812a
Compare
307812a
to
d351584
Compare
Thanks! |
Related Issues
Proposed Changes
yes
to import the snapshotAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps