Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs: Update release_issue_template.md #11587

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jan 18, 2024

Proposed Changes

Update the release_issue_template.md, removing some outdated checks

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Update release_issue_template.md
@rjan90 rjan90 requested a review from a team as a code owner January 18, 2024 08:36
@rjan90 rjan90 requested review from aarshkshah1992 and removed request for aarshkshah1992 and arajasek March 22, 2024 08:18
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 seems like a lot of steps being removed, are those no longer relevant? are they important to mention in some way?

rjan90 and others added 2 commits March 26, 2024 08:44
Co-authored-by: Rod Vagg <rod@vagg.org>
Call-out that testing of the RC should be done.
@rjan90
Copy link
Contributor Author

rjan90 commented Mar 26, 2024

I added a callout for testing the RC, but most of those checkboxes was very outdated, like doing testing the SPX.

@rjan90 rjan90 merged commit 3cb9b6c into master Mar 26, 2024
96 checks passed
@rjan90 rjan90 deleted the phi-update-release-template branch March 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants