feat: eth: remove support for ETH tracing APIs #11596
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11356
Proposed Changes
Unfortunately, these APIs turned out to be very difficult to correctly support given all the differences between Filecoin and Ethereum. The fact of the matter is that Filecoin is not Ethereum. We strive for Ethereum compatibility from the perspective of builders, but that doesn't mean that the Filecoin chain can be accurately indexed as if it were an Ethereum chain.
Issues with the Eth-JSON RPC API include:
That's not to say that all this is impossible to fix. However:
Additional Info
This is a request for comments, not a final proposal. But "do nothing" isn't really an option. We either need to remove it and or fix it.
For some context, I also have a 90% done patch to "fix" most of the issues in the trace API (required some changes in the FVM itself to expose more information in traces). Unfortunately, that's 90% feature-complete not 90% tested. There are no tests right now and writing enough tests to be sure of this API would take quite a bit of work. And even then, I this isn't something I want to maintain.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps