Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drand: refactor round verification #11598

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

arajasek
Copy link
Contributor

Related Issues

This is a refactor of some of the beacon logic in preparation of FIP-0063, although this doesn't actually implement any logic towards that.

We currently assume that the beacon entries included in blocks must make a contiguous chain (no skipped rounds). This is currently needed, because we're using chained randomness.

Proposed Changes

This PR doesn't lead to any change in behaviour, but changes the logic to instead rely on expected rounds. We expect a certain round for every epoch, and include the beacon entry corresponding to that round in our blocks.

This makes the logic easier to extend when we switch to unchained randomness with a different period than Filecoin.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner January 24, 2024 23:54
var out []types.BeaconEntry
for cur > prev.Round {
rch := beacon.Entry(ctx, cur)
for currEpoch > parentEpoch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for currEpoch > parentEpoch {
for currEpoch := epoch; currEpoch > parentEpoch; curEpoch-- {

@arajasek arajasek merged commit 057cef5 into master Jan 25, 2024
87 of 88 checks passed
@arajasek arajasek deleted the asr/prefactor-drand branch January 25, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants