feat: drand: refactor round verification #11598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This is a refactor of some of the beacon logic in preparation of FIP-0063, although this doesn't actually implement any logic towards that.
We currently assume that the beacon entries included in blocks must make a contiguous chain (no skipped rounds). This is currently needed, because we're using chained randomness.
Proposed Changes
This PR doesn't lead to any change in behaviour, but changes the logic to instead rely on expected rounds. We expect a certain round for every epoch, and include the beacon entry corresponding to that round in our blocks.
This makes the logic easier to extend when we switch to unchained randomness with a different period than Filecoin.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps