Add lotus-provider to build to match install #11616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjan90
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Confirmed to fix the error:
go build -ldflags="-X=github.com/filecoin-project/lotus/build.CurrentCommit=+git.16b3f12c8.dirty" -o lotus ./cmd/lotus
rm -f lotus-miner
go build -ldflags="-X=github.com/filecoin-project/lotus/build.CurrentCommit=+git.16b3f12c8.dirty" -o lotus-miner ./cmd/lotus-miner
rm -f lotus-worker
go build -ldflags="-X=github.com/filecoin-project/lotus/build.CurrentCommit=+git.16b3f12c8.dirty" -o lotus-worker ./cmd/lotus-worker
rm -f lotus-provider
go build -ldflags="-X=github.com/filecoin-project/lotus/build.CurrentCommit=+git.16b3f12c8.dirty" -o lotus-provider ./cmd/lotus-provider
Caution: you have an existing lotus binary in your PATH. This may cause problems if you don't run 'sudo make install'
11 tasks
snadrus
approved these changes
Feb 28, 2024
rjan90
pushed a commit
that referenced
this pull request
Mar 20, 2024
Add lotus-provider to build to match install
8 tasks
rjan90
pushed a commit
that referenced
this pull request
Mar 21, 2024
Add lotus-provider to build to match install
rjan90
pushed a commit
that referenced
this pull request
Mar 21, 2024
Add lotus-provider to build to match install
rjan90
pushed a commit
that referenced
this pull request
Mar 22, 2024
Add lotus-provider to build to match install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a mismatch between
buildandinstallin thatinstallalways tries to installlotus-providerand will error if it's not built, butbuilddoesn't build it for you; so amake clean && make build && sudo make installwill always fail.This adds
lotus-providertobuild, but the alternative is to removelotus-providerfrominstall. That option may be more appropriate since it's still under development?