Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust actor event API after review #11649

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Adjust actor event API after review #11649

merged 7 commits into from
Mar 1, 2024

Commits on Feb 26, 2024

  1. Adjust actor event API after review

    @rvagg
    rvagg committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    90f1988 View commit details
    Browse the repository at this point in the history

  2. s/ActorEvents/Events/g in global config

    @rvagg
    rvagg committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0e20f14 View commit details
    Browse the repository at this point in the history

  3. Manage event sending rate for SubscribeActorEvents

    @rvagg
    rvagg committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8a3a461 View commit details
    Browse the repository at this point in the history

  4. Terminate SubscribeActorEvents chan when at max height

    @rvagg
    rvagg committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    28389ff View commit details
    Browse the repository at this point in the history

  5. Document future API changes

    @rvagg
    rvagg committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    d200a43 View commit details
    Browse the repository at this point in the history

  6. More clarity in actor event API docs

    @rvagg
    rvagg committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    99ecc47 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. More post-review changes, lots of tests for SubscribeActorEvents 

    Use BlockDelay as the window for receiving events on the SubscribeActorEvents
channel. We expect the user to have received the initial batch of historical
events (if any) in one block's time. For real-time events we expect them to
not fall behind by roughly one block's time.
    @rvagg
    rvagg committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    9fd3e02 View commit details
    Browse the repository at this point in the history