test: build: Add tests to sanity check embedded built-in actors metadata #11684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
requested review from
jennijuju,
Stebalien,
snadrus,
aarshkshah1992,
magik6k,
ZenGround0,
arajasek,
rjan90 and
rvagg
as code owners
masih
force-pushed
the
masih/test-embedded-car-bundle-metadata
branch
from
cc1042e
to
f95799c
Compare
Stebalien
reviewed
Mar 5, 2024
Stebalien
approved these changes
Mar 5, 2024
rvagg
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Just want to note that I've been running unit tests locally (per #11628) and wouldn't mind if we could try and keep them fairly minimal, and even squish down some of the slow ones we currently have. This is only ~9s for me, which is not the worst, but it all stacks up.
Maybe we should do a pass some time and do a skip based on os.Getenv("CI") to make it more practical. This one would probably be in that category.
|
Can this to be only run in CI when a PR is open against releases branch? |
I have a better idea; I'll change this PR to:
That should significantly shave time off the 10 seconds it takes to run these tests which seems to be an issue. |
masih
force-pushed
the
masih/test-embedded-car-bundle-metadata
branch
from
f95799c
to
4135d5a
Compare
Add tests that assert the embedded built-in actors metadata is correct: * the corresponding CAR file is present in built-in actors released assets as a CAR file. * the corresponding tar.zst is locally present and matches the expected SHA-256 digest * manifest CID is the only root CID in the corresponding CAR file. * actor CIDs are present in the corresponding CAR file. Configure a dedicated CI workflow to only run the tests on: * `release/*` branches, * modification to `build/builtin_actors_gen.go`, * or embedded ZST files. Fixes #11683
masih
force-pushed
the
masih/test-embedded-car-bundle-metadata
branch
from
19af7ea
to
283f6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11683
Proposed Changes
Add tests that assert the embedded built-in actors metadata is correct:
assets as a CAR file.
SHA-256 digest
Configure a dedicated CI workflow to only run the tests on:
release/*branches,build/builtin_actors_gen.go,Additional Info
Note: only the latest network version seem to have
BundleGitTag. Tests depend on this value to fetch the right CAR file.Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps