Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SPTool scaffolding #11740

Closed
wants to merge 11 commits into from
Closed

feat: SPTool scaffolding #11740

wants to merge 11 commits into from

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 18, 2024

Related Issues

This PR starts implementing #11733

Proposed Changes

  • Setup the initial cmd structure
  • Small abstraction for sharing of command code between SPTool and lotus-miner
  • Bring over lotus-miner actor withdraw into the shared package

Additional Info

Not sure if we want to do this as one bigly PR bringing everything over at once, or if we want to land the almost empty binary first, then start bringing over more and more commands in smaller PRs.

I'm slightly leaning towards more smaller PRs, so this PR is ready for review as-is

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus
Copy link
Collaborator

snadrus commented Mar 21, 2024

I've added actors.

@snadrus snadrus requested a review from LexLuthr March 26, 2024 20:59
@snadrus
Copy link
Collaborator

snadrus commented Mar 26, 2024

@magik6k It won't let me add you as a reviewer because I took it over from you.

@snadrus snadrus closed this Mar 26, 2024
@snadrus
Copy link
Collaborator

snadrus commented Mar 26, 2024

recreating this so Magik6k can review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants