Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: Move boost proxy into the main binary #11783

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 26, 2024

Related Issues

This implements the "Move the boost-proxy into Curio + implement some backpressure" part of #11754

Proposed Changes

  • Move lotus-shed/deal.go boost-proxy command into a service in curiosrc/market/lmrpc/lmrpc.go
  • Add a MarketRPCServers []string config for defining market RPC servers in curio subsystems config

Additional Info

TODO:

  • Implement a command creating API info snippets
  • Test on mainnet
  • Add to simple migration?

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k marked this pull request as draft March 26, 2024 12:32
@magik6k magik6k force-pushed the feat/curio-internal-market-proxy branch 4 times, most recently from a836554 to b8a996d Compare March 27, 2024 09:39
@magik6k magik6k marked this pull request as ready for review March 27, 2024 09:54
@magik6k magik6k force-pushed the feat/curio-internal-market-proxy branch from b8a996d to 687eb05 Compare March 27, 2024 09:55
curiosrc/market/lmrpc/lmrpc.go Outdated Show resolved Hide resolved
cmd/curio/market.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr linked an issue Mar 28, 2024 that may be closed by this pull request
@snadrus
Copy link
Collaborator

snadrus commented Mar 28, 2024

where is the backpressure logic defined? It could use commenting.

@magik6k
Copy link
Contributor Author

magik6k commented Mar 29, 2024

No backpressure in this PR, will implement in a follow-up

@snadrus
Copy link
Collaborator

snadrus commented Apr 2, 2024

@magik6k needs: make gen docsgen-cli

@magik6k magik6k force-pushed the feat/curio-internal-market-proxy branch from 92a9f75 to a670f98 Compare April 3, 2024 13:34
@snadrus snadrus merged commit f8a5aa0 into master Apr 3, 2024
184 checks passed
@snadrus snadrus deleted the feat/curio-internal-market-proxy branch April 3, 2024 16:31
Nagaprasadvr pushed a commit to Nagaprasadvr/lotus that referenced this pull request Apr 4, 2024
…11783)

* feat: curio: Move boost proxy into the main binary

* curio: Command for generating market tokens

* curio boost rpc: Address review

* make docsgen-cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish Boost integration with Curio
2 participants