Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ci: migrate the release workflow to github actions #11785

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 26, 2024

Related Issues

#11734

Proposed Changes

This PR creates two new GitHub Actions workflows (docker.yml and release.yml) that perform the following jobs previously handled exclusively by CircleCI:

  • docker-*
  • release-*

Additional Info

You can find the example of a Docker publish at: https://github.com/filecoin-project/lotus/actions/runs/8438620518
You can find the example of a release publish at: https://github.com/filecoin-project/lotus/actions/runs/8438620515

Note that both Docker as well as release will operate exclusively in a dry run mode until CircleCI is deprecated. This is to prevent duplicate publishing.

The newly added workflows need the following vars/secrets set up before they can be brought out of the dry run mode:

  • vars.DOCKERHUB_USERNAME
  • secrets. DOCKERHUB_TOKEN
  • secrets.GORELEASER_KEY

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more paranoid suggestion, otherwise LGTM.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@galargh galargh merged commit 2a0d897 into master Apr 2, 2024
190 of 191 checks passed
@galargh galargh deleted the ci/ipdx-gha-release branch April 2, 2024 13:22
Nagaprasadvr pushed a commit to Nagaprasadvr/lotus that referenced this pull request Apr 4, 2024
…ect#11785)

* ci: rename install ubuntu deps to install system dependencies

* ci: migrate the release workflow to github actions

* ci: set permissions required by the newly added workflows explicitly

* ci: prevent duplicate release and docker publishing

* ci: trigger docker workflow on push to master

* ci: do not pass tokens to goreleaser on dry release runs

* ci: specify higher permissions on a job level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants