-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ci: migrate the release workflow to github actions #11785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Mar 26, 2024
Stebalien
reviewed
Mar 27, 2024
Stebalien
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more paranoid suggestion, otherwise LGTM.
Nagaprasadvr
pushed a commit
to Nagaprasadvr/lotus
that referenced
this pull request
Apr 4, 2024
…ect#11785) * ci: rename install ubuntu deps to install system dependencies * ci: migrate the release workflow to github actions * ci: set permissions required by the newly added workflows explicitly * ci: prevent duplicate release and docker publishing * ci: trigger docker workflow on push to master * ci: do not pass tokens to goreleaser on dry release runs * ci: specify higher permissions on a job level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#11734
Proposed Changes
This PR creates two new GitHub Actions workflows (
docker.yml
andrelease.yml
) that perform the following jobs previously handled exclusively by CircleCI:Additional Info
You can find the example of a Docker publish at: https://github.com/filecoin-project/lotus/actions/runs/8438620518
You can find the example of a release publish at: https://github.com/filecoin-project/lotus/actions/runs/8438620515
Note that both Docker as well as release will operate exclusively in a dry run mode until CircleCI is deprecated. This is to prevent duplicate publishing.
The newly added workflows need the following vars/secrets set up before they can be brought out of the dry run mode:
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps