refactor: cli: Avoid disputing WindowedPoSt messages when the target miner has no balance to pay rewards #11800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nagaprasadvr
changed the title
Stebalien
approved these changes
Apr 3, 2024
Stebalien
requested changes
Apr 3, 2024
Nagaprasadvr
force-pushed
the
refactor-cli-avoid-disputing-windowedPoSt-messages-when-the-target-miner-has-no-balance-to-pay-rewards
branch
from
5ac6b25
to
46b45f6
Compare
Stebalien
reviewed
Apr 4, 2024
Stebalien
approved these changes
Apr 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid disputing WindowedPoSt messages when the target Miner has no balance to pay rewards
Related Issues
fixes #11715
Proposed Changes
In #11703, a user came across an edge case where an SP:
This left the SP's miner actor with a bad proof but without any funds to pay for disputes. On the other hand, given that the sectors have been terminated and termination fees were already paid we don't really care about fining the SP for the bad proofs anyways.
But... we still don't want to submit dispute messages in this case because doing so isn't free and doesn't really serve a purpose.
So add a check to fetch miner wallet balance and only send disputing messages if balance is non zero.
Additional Info
look at disputer.go line no 241 onwards