Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: harmony: Try other tasks when storage claim fails #11826

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 4, 2024

Related Issues

Proposed Changes

Before this fix if considerWork was called with a bunch of tasks, and the one selected first by CanAccept was consistently failing to claim storage, we'd get stuck never trying to claim other tasks. Combined with the bug in storage reservations (#11825) this could lead to pile-ups which would make everything clog up, and no tasks would get executed.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k merged commit 485050e into master Apr 5, 2024
186 checks passed
@magik6k magik6k deleted the fix/harmony-claim-nofail-all branch April 5, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants