Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test: TestForkPreMigration hanging when env-var is set #11838

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Apr 5, 2024

Related Issues

Fixes #11824

The TestForkPreMigration-test would hang indefinitely if the LOTUS_DISABLE_PRE_MIGRATIONS=1 environment variable was set.

Proposed Changes

Temporarily unsets the LOTUS_DISABLE_PRE_MIGRATIONS environment variable before running the test, and restore it afterward.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Unset LOTUS_DISABLE_PRE_MIGRATIONS env-var for TestForkPreMigration test, so it does not hang
Err-check to make lint happy
@rjan90 rjan90 merged commit 385fb7a into master Apr 5, 2024
186 checks passed
@rjan90 rjan90 deleted the phi-TestForkPreMigration-fix branch April 5, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

Test TestForkPreMigration hangs if LOTUS_DISABLE_PRE_MIGRATIONS=1 is set in the environment
2 participants