Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: add allocation check before sending commit message #11841

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Apr 5, 2024

Related Issues

Fixes #11837

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr requested review from magik6k and rvagg April 5, 2024 13:50
@rvagg
Copy link
Member

rvagg commented Apr 19, 2024

lgtm, other than the minor comments

@LexLuthr LexLuthr requested a review from rvagg April 19, 2024 12:38
@magik6k magik6k merged commit 103a7e0 into master Apr 19, 2024
186 checks passed
@magik6k magik6k deleted the fix/commit-alloc-check branch April 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miner: CommitBatcher#processBatchV2 should check allocations can be claimed before executing (DDO UX)
3 participants