Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: Cleanup data copies after seal ops #11847

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 7, 2024

Related Issues

Proposed Changes

This PR makes it so that after each porep pipeline step tasks will ensure that only the latest version of sector files remain in storage. This should make future retry logic much easier to implement - e.g. retrying SDR will now just be setting after_sdr/after_tree.. fields for a given sector to false.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k force-pushed the feat/curio-postseal-onecopy branch from 0933af1 to 9a8785c Compare April 7, 2024 18:44
@magik6k magik6k force-pushed the feat/curio-postseal-onecopy branch from 9a8785c to bff8f79 Compare April 7, 2024 18:55
@magik6k magik6k marked this pull request as draft April 8, 2024 11:46
@magik6k
Copy link
Contributor Author

magik6k commented Apr 8, 2024

Seems to be broken in some mysterious way, trying to debug what's going on here

@magik6k magik6k marked this pull request as ready for review April 9, 2024 09:27
@magik6k magik6k requested review from snadrus and LexLuthr April 9, 2024 09:27
@magik6k magik6k requested a review from snadrus April 11, 2024 16:10
@snadrus snadrus merged commit 3cc62e0 into master Apr 11, 2024
185 of 186 checks passed
@snadrus snadrus deleted the feat/curio-postseal-onecopy branch April 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants