Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: Use Yugabyte's PGX driver #11887

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: curio: Use Yugabyte's PGX driver #11887

merged 2 commits into from
Apr 18, 2024

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Apr 17, 2024

Related Issues

This enables load balancing and failover in a Yugabyte-standard way.

Proposed Changes

Use yugabyte's pgx/v5 instead of the default pgx.
Note: Get() was removed as it is duplicates functionality available with less code.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from magik6k April 17, 2024 19:22
@magik6k magik6k changed the title Use Yugabyte's PGX driver feat: curio: Use Yugabyte's PGX driver Apr 18, 2024
@magik6k magik6k merged commit edd9c82 into master Apr 18, 2024
186 checks passed
@magik6k magik6k deleted the feat/yb-pgx branch April 18, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants