Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: curio: Update pgx imports, fix db_storage alloc #11910

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 20, 2024

Related Issues

  • Undo the change from fix: curio: fix incorrect null check for varchar column #11881
    • heartbeat_err is a nullable varchar, and afaict it's completely ignored in the db_index (it's not ever set anywhere); The string based check was definitely broken for me
  • Also update pgx imports to the yugabyte one so that ErrNoRows checks work correctly

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k enabled auto-merge (rebase) April 21, 2024 14:28
@magik6k magik6k merged commit 4c8bfa5 into release/curio-beta Apr 22, 2024
184 of 186 checks passed
@magik6k magik6k deleted the fix/curio-storage-alloc branch April 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants