Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: Keep more sector metadata in the DB long-term #11933

Merged
merged 10 commits into from
May 7, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 26, 2024

Related Issues

Proposed Changes

  • Add 2 new tables for sector metadata to the DB
  • Add migration logic for those invoked in guided-setup and optionally as a curio cli command
  • Add logic which populates the table from seal pipeline at the end of the commit-msg task.

Additional Info

TODO:

  • Test migration on a real setup
  • Check that sectors sealed with curio will get added to the long-term metadata table
  • Add the missing "keep unsealed" bool to curio seal pipeline

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k force-pushed the feat/curio-more-sector-meta branch 3 times, most recently from af7a2f8 to 506ad86 Compare April 29, 2024 10:59
@magik6k magik6k marked this pull request as ready for review April 30, 2024 07:49
@magik6k magik6k force-pushed the feat/curio-more-sector-meta branch from 506ad86 to 205418e Compare May 2, 2024 09:50
@magik6k magik6k force-pushed the feat/curio-more-sector-meta branch from 96bcc7a to 2e81240 Compare May 2, 2024 10:04
@LexLuthr LexLuthr changed the base branch from master to release/curio-beta May 2, 2024 10:37
@LexLuthr LexLuthr changed the base branch from release/curio-beta to master May 2, 2024 10:38
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a small nit.

cmd/curio/guidedsetup/shared.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit 01ec229 into master May 7, 2024
186 checks passed
@magik6k magik6k deleted the feat/curio-more-sector-meta branch May 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants