Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui-listen fix #12013

Merged
merged 3 commits into from
May 22, 2024
Merged

gui-listen fix #12013

merged 3 commits into from
May 22, 2024

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented May 17, 2024

Related Issues

  • avoid collision of --listen and --gui-listen
  • Ensure listening on all IPs by default

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from LexLuthr May 17, 2024 14:22
Copy link

github-actions bot commented May 17, 2024

All checks have completed

❌ Failed Test / Test (itest-deals_partial_retrieval_dm-level) (pull_request)

@snadrus snadrus mentioned this pull request May 17, 2024
8 tasks
@magik6k magik6k merged commit 75ca4de into master May 22, 2024
95 of 96 checks passed
@magik6k magik6k deleted the fix/guilisten branch May 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants