-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ci: keep lotus checkout clean in the release workflow #12028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galargh
changed the title
ci: fix: keep lotus checkout clean in the release workflow
fix: ci: keep lotus checkout clean in the release workflow
May 22, 2024
All checks have passed |
galargh
force-pushed
the
ci/ipdx-goreleaser-fix
branch
from
May 22, 2024 07:21
0ffdbaf
to
9c2a844
Compare
To fully verify the fixes introduced here, I released v1.27.0-rc3 using https://github.com/filecoin-project/lotus/actions/runs/9189206215. I also released accompanying docker images using https://github.com/filecoin-project/lotus/actions/runs/9189413087. |
rjan90
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
https://github.com/filecoin-project/lotus/actions/runs/9124502463/job/25262400685#step:8:71
Proposed Changes
Check out lotus under
lotus
directory.Additional Info
By checking out
lotus
under a separate directory, we ensure that the checkout remains clean after we download prebuilt lotus binaries under other directories in the GitHub workspace directory.This should fix the issue we encountered with goreleaser complaining about the dirty state of the lotus checkout.
Additionally, I added the ability to provide the release workflow with an arbitrary tag. This will allow us to use the fixed version of the workflow to release a pre-existing tag.
Finally, I also fixed the Docker release workflow and patched it up in a way that allows releasing historical tags.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps