Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci: keep lotus checkout clean in the release workflow #12028

Merged
merged 13 commits into from
May 22, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented May 22, 2024

Related Issues

https://github.com/filecoin-project/lotus/actions/runs/9124502463/job/25262400685#step:8:71

Proposed Changes

Check out lotus under lotus directory.

Additional Info

By checking out lotus under a separate directory, we ensure that the checkout remains clean after we download prebuilt lotus binaries under other directories in the GitHub workspace directory.

This should fix the issue we encountered with goreleaser complaining about the dirty state of the lotus checkout.

Additionally, I added the ability to provide the release workflow with an arbitrary tag. This will allow us to use the fixed version of the workflow to release a pre-existing tag.

Finally, I also fixed the Docker release workflow and patched it up in a way that allows releasing historical tags.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@galargh galargh changed the title ci: fix: keep lotus checkout clean in the release workflow fix: ci: keep lotus checkout clean in the release workflow May 22, 2024
Copy link

github-actions bot commented May 22, 2024

All checks have passed

@galargh
Copy link
Contributor Author

galargh commented May 22, 2024

To fully verify the fixes introduced here, I released v1.27.0-rc3 using https://github.com/filecoin-project/lotus/actions/runs/9189206215. I also released accompanying docker images using https://github.com/filecoin-project/lotus/actions/runs/9189413087.

@galargh galargh marked this pull request as ready for review May 22, 2024 10:20
@rjan90 rjan90 merged commit cfbe59d into master May 22, 2024
105 checks passed
@rjan90 rjan90 deleted the ci/ipdx-goreleaser-fix branch May 22, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants