Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: api: the Net API/CLI now remains only on daemon #12100

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

ribasushi
Copy link
Collaborator

The only part of this repository that does lp2p is now lotus-daemon

Remove the CommonNet type, used exclusively bu the CLI stack

Adjust the rest of struct-memebership to match what went where

End result best seen in diff of documentation/en/api-v0-methods-miner.md

The only part of this repository that does lp2p is now lotus-daemon

Remove the CommonNet type, used exclusively bu the CLI stack

Adjust the rest of struct-memebership to match what went where

End result best seen in diff of `documentation/en/api-v0-methods-miner.md`
@ribasushi ribasushi marked this pull request as ready for review June 17, 2024 07:25
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, I thought'd we'd dealt with that but obviously not!

@rvagg rvagg merged commit 8cd233b into filecoin-project:master Jun 17, 2024
75 checks passed
@ribasushi ribasushi deleted the chore/cleanup-miner-api branch June 17, 2024 08:32
@aarshkshah1992
Copy link
Contributor

This is great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants