Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs: Add initial Update_Dependencies_Lotus.md #12107

Merged
merged 14 commits into from
Jul 3, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jun 18, 2024

Proposed Changes

Add a document detialing how to update the most common dependencies in Lotus.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Add initial `Update_Dependencies_Lotus.md`
Copy link

github-actions bot commented Jun 18, 2024

All checks have passed

@BigLep
Copy link
Member

BigLep commented Jun 18, 2024

2024-06-18 conversation: lets also add an optional "if doing a network upgrade" section to https://github.com/filecoin-project/lotus/blob/master/documentation/misc/RELEASE_ISSUE_TEMPLATE.md that links to this doc.

rjan90 added 2 commits June 18, 2024 22:47
Update the `Update_Dependecies_Lotus.md` file
Update link to Filecoin-FFI release process
@rjan90 rjan90 mentioned this pull request Jun 18, 2024
55 tasks
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Looking good to me. I left some small comments and there is also #12107 (comment)

documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
documentation/misc/Update_Dependencies_Lotus.md Outdated Show resolved Hide resolved
@BigLep BigLep mentioned this pull request Jun 21, 2024
5 tasks
rjan90 and others added 9 commits July 1, 2024 08:50
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Add optional step in the Release_Issue_Template that links to the Update_Dependencies_Lotus.md document
@rjan90
Copy link
Contributor Author

rjan90 commented Jul 1, 2024

2024-06-18 conversation: lets also add an optional "if doing a network upgrade" section to https://github.com/filecoin-project/lotus/blob/master/documentation/misc/RELEASE_ISSUE_TEMPLATE.md that links to this doc.

This has been addressed in: cb9257e

Move Ref-FVM section before Filecoin-FFI since it happens before updating Filecoin-FFI
@rjan90 rjan90 changed the title Add initial Update_Dependencies_Lotus.md chore: docs: Add initial Update_Dependencies_Lotus.md Jul 1, 2024
@rjan90 rjan90 marked this pull request as ready for review July 1, 2024 08:31
Co-authored-by: Rod Vagg <rod@vagg.org>
@rjan90 rjan90 enabled auto-merge (squash) July 3, 2024 06:49
@rjan90 rjan90 merged commit 935a77f into master Jul 3, 2024
78 checks passed
@rjan90 rjan90 deleted the phi/update-deps-doc branch July 3, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants