Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release: v1.28.0-rc5 #12213

Merged
merged 2 commits into from
Jul 11, 2024
Merged

build: release: v1.28.0-rc5 #12213

merged 2 commits into from
Jul 11, 2024

Conversation

aarshkshah1992
Copy link
Contributor

Builds release v1.28.0-rc5

@aarshkshah1992 aarshkshah1992 requested a review from rjan90 July 11, 2024 12:41
@rjan90 rjan90 changed the title build: release v1.28.0-rc5 build: release: v1.28.0-rc5 Jul 11, 2024
rjan90
rjan90 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One nit: Add the backport PR that led to shipping this rc5 to the changelog: #12212

@aarshkshah1992
Copy link
Contributor Author

@rjan90 Done.

@aarshkshah1992
Copy link
Contributor Author

Failures are known flakies.

@aarshkshah1992
Copy link
Contributor Author

Merging as Orjan as approved and we've decided that one approval on release branches is good enough going ahead.

@aarshkshah1992 aarshkshah1992 merged commit 316b6fc into release/v1.28.0 Jul 11, 2024
76 of 78 checks passed
@aarshkshah1992 aarshkshah1992 deleted the aarshkshah1992/v1280-rc5 branch July 11, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjan90 rjan90 rjan90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarshkshah1992 @rjan90