Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ci: upload junit xml reports to buildpulse #12225

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Jul 12, 2024

Related Issues

#12127

Proposed Changes

Create a workflow that uploads junit XML reports that the Test workflow produces to BuildPulse.

Additional Info

This PR depends on setting up the following repository variables:

  • BUIDPULSE_ACCOUNT_ID
  • BUILDPULSE_REPOSITORY_ID
  • BUILDPULSE_ACCESS_KEY_ID

And the following repository secrets:

  • BUILDPULSE_SECRET_ACCESS_KEY

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@galargh galargh requested a review from BigLep July 12, 2024 13:04
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments may be newbie as someone who hasn't done much with GHA.

.github/workflows/build-pulse.yml Show resolved Hide resolved
.github/workflows/build-pulse.yml Show resolved Hide resolved
.github/workflows/build-pulse.yml Outdated Show resolved Hide resolved
.github/workflows/build-pulse.yml Outdated Show resolved Hide resolved
Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I assume we'll only be able to see what BuildPulse looks like after this gets merged.

@galargh
Copy link
Contributor Author

galargh commented Jul 16, 2024

Looks good to me. I assume we'll only be able to see what BuildPulse looks like after this gets merged.

Yes, we'll also need the following set up in the repo.

Repository variables:

  • BUIDPULSE_ACCOUNT_ID
  • BUILDPULSE_REPOSITORY_ID
  • BUILDPULSE_ACCESS_KEY_ID

Repository secrets:

  • BUILDPULSE_SECRET_ACCESS_KEY

Would you be able to do it? If you need any help with that, let me know.

I'm going to merge this and disable the workflow. We can then reenable it once we have the secrets we need set up.

@galargh galargh merged commit af934be into master Jul 16, 2024
78 checks passed
@galargh galargh deleted the ipdx/buildpulse branch July 16, 2024 11:09
@BigLep
Copy link
Member

BigLep commented Jul 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants