Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments for struct field #12241

Closed
wants to merge 1 commit into from

Conversation

linghuying
Copy link
Contributor

Related Issues

Proposed Changes

fix some comments for struct field

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Signed-off-by: linghuying <1599935829@qq.com>
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Jul 16, 2024
@rvagg
Copy link
Member

rvagg commented Jul 16, 2024

@linghuying thanks, you'll need to make gen and check in the changes from this please

@linghuying
Copy link
Contributor Author

s, you'll need to make gen and check in the changes from this please

Sorry. I get an error message:

chain/consensus/utils.go:12:2: github.com/filecoin-project/filecoin-ffi@v1.28.0-rc2 (replaced by ./extern/filecoin-ffi): reading extern/filecoin-ffi/go.mod: open /Users/sc/github/linghuying-github/lotus/extern/filecoin-ffi/go.mod: no such file or directory chain/vm/fvm.go:21:2: github.com/filecoin-project/filecoin-ffi@v1.28.0-rc2 (replaced by ./extern/filecoin-ffi): reading extern/filecoin-ffi/go.mod: open /Users/sc/github/linghuying-github/lotus/extern/filecoin-ffi/go.mod: no such file or directory make: *** [type-gen] Error 1

@rvagg
Copy link
Member

rvagg commented Jul 16, 2024

@linghuying make deps to get that set up

@linghuying
Copy link
Contributor Author

make gen

Sorry, I execute make deps && make gen and get another error:

chain/actors/policy/policy.go itests/kit/ensemble_opts_nv.go go run ./gen/api goimports -w api goimports -w api go run ./gen/main.go github.com/filecoin-project/filecoin-ffi/cgo: exec: "pkg-config": executable file not found in $PATH make: *** [type-gen] Error 1

@rvagg
Copy link
Member

rvagg commented Jul 22, 2024

Sorry @linghuying, it's a bit more complicated if you've not done it for the first time. See https://lotus.filecoin.io/lotus/install/prerequisites/#supported-platforms and click on your OS at the bottom and it'll show you some basic install instructions for a few dependencies, like pkg-config.

@ribasushi
Copy link
Collaborator

@linghuying just apply this patch and push - all tests should pass

diff --git a/build/openrpc/full.json b/build/openrpc/full.json
index 41a4a6054..910fb9c47 100644
--- a/build/openrpc/full.json
+++ b/build/openrpc/full.json
@@ -20921 +20921 @@
-            "summary": "StateMinerInitialPledgeCollateral returns the precommit deposit for the specified miner's sector\n",
+            "summary": "StateMinerPreCommitDepositForPower returns the precommit deposit for the specified miner's sector\n",
diff --git a/documentation/en/api-v0-methods.md b/documentation/en/api-v0-methods.md
index 815a74cdd..1302f15d9 100644
--- a/documentation/en/api-v0-methods.md
+++ b/documentation/en/api-v0-methods.md
@@ -5169 +5169 @@ Response:
-StateMinerInitialPledgeCollateral returns the precommit deposit for the specified miner's sector
+StateMinerPreCommitDepositForPower returns the precommit deposit for the specified miner's sector
diff --git a/documentation/en/api-v1-unstable-methods.md b/documentation/en/api-v1-unstable-methods.md
index ecb9053b2..81e1af72b 100644
--- a/documentation/en/api-v1-unstable-methods.md
+++ b/documentation/en/api-v1-unstable-methods.md
@@ -7113 +7113 @@ Response:
-StateMinerInitialPledgeCollateral returns the precommit deposit for the specified miner's sector
+StateMinerPreCommitDepositForPower returns the precommit deposit for the specified miner's sector

@rvagg
Copy link
Member

rvagg commented Aug 12, 2024

completed via #12376

@rvagg rvagg closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants