Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] chore: types: buildconstants split post-cleanup #12245

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

ribasushi
Copy link
Collaborator

Related Issues

Followup fixes to #12112

@ribasushi ribasushi marked this pull request as ready for review July 16, 2024 08:38
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks for catching these

@rvagg rvagg merged commit 673c3ff into filecoin-project:master Jul 16, 2024
78 checks passed
@ribasushi ribasushi deleted the chore/buildocnstants_cleanup branch July 16, 2024 09:12
@rjan90
Copy link
Contributor

rjan90 commented Jul 16, 2024

Similar to #12112 wrt the backport label:

As discussed in Slack, I will remove the release/backport label, because we will not be backporting this PR to the v1.28.0 train. Instead we will follow up shipping these changes in a subsequent release fairly quick after the stable v1.28.0 is out on July 23rd.

ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Jul 17, 2024
* chore: s/CidMustParse/cid.MustParse/g
* chore: fix sloppy init duplication
* chore: move the policy init() to the core namespace
* chore: remove unused proxies for policy.DealDurationBounds
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Jul 17, 2024
* chore: s/CidMustParse/cid.MustParse/g
* chore: fix sloppy init duplication
* chore: move the policy init() to the core namespace
* chore: remove unused proxies for policy.DealDurationBounds
@rjan90 rjan90 mentioned this pull request Jul 23, 2024
8 tasks
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Jul 24, 2024
* chore: s/CidMustParse/cid.MustParse/g
* chore: fix sloppy init duplication
* chore: move the policy init() to the core namespace
* chore: remove unused proxies for policy.DealDurationBounds
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 17, 2024
* chore: s/CidMustParse/cid.MustParse/g
* chore: fix sloppy init duplication
* chore: move the policy init() to the core namespace
* chore: remove unused proxies for policy.DealDurationBounds
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
* chore: s/CidMustParse/cid.MustParse/g
* chore: fix sloppy init duplication
* chore: move the policy init() to the core namespace
* chore: remove unused proxies for policy.DealDurationBounds
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
* chore: s/CidMustParse/cid.MustParse/g
* chore: fix sloppy init duplication
* chore: move the policy init() to the core namespace
* chore: remove unused proxies for policy.DealDurationBounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants