[skip changelog] chore: types: buildconstants split post-cleanup #12246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technically the entire "what are we building" should stay in build/... , not having the static-ish machinery split across 2 namespaces is an improvement
ribasushi
force-pushed
the
chore/buildconstants_cleanup
branch
2 times, most recently
from
cf7e5bb to
22cf119
Compare
This is a large diff, yet should have exactly zero functional changes Ideally as a result of this some parts of the depchain will become lighter, with downstream reaping the same benefits as the team that initiated this split. P.S. work was done while forming better intuition of current dependency graph
ribasushi
force-pushed
the
chore/buildconstants_cleanup
branch
from
22cf119 to
33b9869
Compare
|
@rvagg @ZenGround0 (can't request reviewers). This is mostly mechanical, but who knows... |
aarshkshah1992
approved these changes
Jul 22, 2024
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jul 23, 2024
Makes testground build again, namely: for d in ./cmd/lotus*; do go build -tags testground -o /dev/null $d || break ; done
rvagg
pushed a commit
that referenced
this pull request
Jul 24, 2024
Makes testground build again, namely: for d in ./cmd/lotus*; do go build -tags testground -o /dev/null $d || break ; done
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jul 24, 2024
Makes testground build again, namely: for d in ./cmd/lotus*; do go build -tags testground -o /dev/null $d || break ; done
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 17, 2024
Makes testground build again, namely: for d in ./cmd/lotus*; do go build -tags testground -o /dev/null $d || break ; done
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
Makes testground build again, namely: for d in ./cmd/lotus*; do go build -tags testground -o /dev/null $d || break ; done
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
Makes testground build again, namely: for d in ./cmd/lotus*; do go build -tags testground -o /dev/null $d || break ; done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Another followup to #12112
🧵 musing about root cause: https://filecoinproject.slack.com/archives/CP50PPW2X/p1721133178627459
Proposed Changes
Remove multiple uses of deprecated constants. This is a large diff, yet should have exactly zero functional changes.
Ideally as a result of this some parts of the depchain will become lighter, with downstream reaping the same benefits as the team that initiated this split.
P.S. work was done as a result of forming better intuition of current dependency graph