-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Eth Event Receipt Logs: use event index for logs #12269
fix: Eth Event Receipt Logs: use event index for logs #12269
Conversation
As per my testing methodology for mainnet in #12262 (comment) (using a recent transaction for that same contract):
(no output) So it looks correct. In this case
|
40aa442
to
7d9e21e
Compare
@aarshkshah1992 I just discovered this: #10287 which has some notes about potential speed-ups. Not necessary for this PR but important to file away in the memory banks because it goes to the speed concerns that are similar to trace_block and trace_filter. |
@rvagg Yeah I am putting together a list of high value work items for RPC and will add it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions in there
Co-authored-by: Rod Vagg <rod@vagg.org>
c193b32
to
45baa76
Compare
…ct#12269) * use event index for receipt logs * tests * increment event count if there is an address mismatch * itests for receipt logs consistency * update ChangeLog * changes as per review * do not increment event count if address resolution fails * Apply suggestions from code review Co-authored-by: Rod Vagg <rod@vagg.org> * address review --------- Co-authored-by: Rod Vagg <rod@vagg.org>
Closes #12254.