Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog]feat: p2p: environment variables for disabling DHT query filter and routing table filter #12289

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 24, 2024

Related Issues

ChainSafe/forest#4576
ChainSafe/forest#4580
ChainSafe/forest#4581

Proposed Changes

We're setting up local and CI regression tests for Forest bootstrap node to make sure the Kademlia setup works for Lotus. In both test scenarios the bootstrap node has no public IP, and we need to disable the DHT PublicRoutingTableFilter in Lotus. This PR introduces environment variables for doing that.

(Skipping changelog as this is more of a developer-facing feature)

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@hanabi1224 hanabi1224 changed the title feat: p2p: environment variables for disabling DHT query filter and outing table filter feat: p2p: [skip changelog]environment variables for disabling DHT query filter and outing table filter Jul 24, 2024
@hanabi1224 hanabi1224 changed the title feat: p2p: [skip changelog]environment variables for disabling DHT query filter and outing table filter feat: p2p: [skip changelog] environment variables for disabling DHT query filter and outing table filter Jul 24, 2024
@hanabi1224 hanabi1224 changed the title feat: p2p: [skip changelog] environment variables for disabling DHT query filter and outing table filter [skip changelog]feat: p2p: environment variables for disabling DHT query filter and outing table filter Jul 24, 2024
@hanabi1224 hanabi1224 changed the title [skip changelog]feat: p2p: environment variables for disabling DHT query filter and outing table filter [skip changelog]feat: p2p: environment variables for disabling DHT query filter and routing table filter Jul 24, 2024
@hanabi1224 hanabi1224 marked this pull request as ready for review July 24, 2024 07:16
@aarshkshah1992 aarshkshah1992 merged commit b4acecd into filecoin-project:master Jul 25, 2024
89 of 90 checks passed
@BigLep
Copy link
Member

BigLep commented Jul 25, 2024

Is there a corresponding docs change needed with this so users know about this toggle?

@rvagg
Copy link
Member

rvagg commented Jul 25, 2024

I'm not sure we have a good place to put such things; we don't expect much use of this beyond what ChainSafe are doing.

git grep .Getenv.*LOTUS | awk -F'"' '{print $2}' | sort | uniq shows 38 such environment variables, most not documented anywhere.

I think it's OK to treat this as a secret little dev backdoor to an bit of functionality most people will never need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants