Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #12333

Merged
merged 1 commit into from
Aug 2, 2024
Merged

chore: fix some comments #12333

merged 1 commit into from
Aug 2, 2024

Conversation

riskrose
Copy link
Contributor

@riskrose riskrose commented Aug 2, 2024

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Signed-off-by: riskrose <riskrock@qq.com>
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rvagg rvagg enabled auto-merge (squash) August 2, 2024 03:12
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Aug 2, 2024
@rvagg rvagg merged commit 10f6976 into filecoin-project:master Aug 2, 2024
82 of 83 checks passed
rjan90 pushed a commit that referenced this pull request Aug 12, 2024
Signed-off-by: riskrose <riskrock@qq.com>
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Aug 20, 2024
Signed-off-by: riskrose <riskrock@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants