docs: expand CONTRIBUTING.md and update README.md
#12366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expanded CONTRIBUTING.md with detailed guidelines - Updated README.md
docs: fix links in pull_request_template.md
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/README.md#pr-title-conventions
rjan90
changed the title
CONTRIBUTING.md and update README.mdCONTRIBUTING.md and update README.md
github-actions
bot
dismissed
their stale review
PR title now matches the required format.
BigLep
approved these changes
Aug 9, 2024
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
BigLep
added a commit
that referenced
this pull request
Aug 9, 2024
BigLep
added a commit
that referenced
this pull request
Aug 12, 2024
#12372) * docs: updating CONTRIBUTING.md with table of contents and TOC guidance This is followup to #12366 (comment) * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <orjan.roren@gmail.com> --------- Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
rjan90
added a commit
to hanabi1224/lotus
that referenced
this pull request
Aug 12, 2024
…ct#12366) * docs: Expand CONTRIBUTING.md - Expanded CONTRIBUTING.md with detailed guidelines - Updated README.md * docs: fix links in pull_request_template.md docs: fix links in pull_request_template.md * Update CONTRIBUTING.md Co-authored-by: Steve Loeppky <biglep@protocol.ai> --------- Co-authored-by: Steve Loeppky <biglep@protocol.ai>
rjan90
added a commit
to hanabi1224/lotus
that referenced
this pull request
Aug 12, 2024
filecoin-project#12372) * docs: updating CONTRIBUTING.md with table of contents and TOC guidance This is followup to filecoin-project#12366 (comment) * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <orjan.roren@gmail.com> --------- Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
rjan90
added a commit
that referenced
this pull request
Aug 12, 2024
* docs: Expand CONTRIBUTING.md - Expanded CONTRIBUTING.md with detailed guidelines - Updated README.md * docs: fix links in pull_request_template.md docs: fix links in pull_request_template.md * Update CONTRIBUTING.md Co-authored-by: Steve Loeppky <biglep@protocol.ai> --------- Co-authored-by: Steve Loeppky <biglep@protocol.ai>
rjan90
added a commit
that referenced
this pull request
Aug 12, 2024
#12372) * docs: updating CONTRIBUTING.md with table of contents and TOC guidance This is followup to #12366 (comment) * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <orjan.roren@gmail.com> --------- Co-authored-by: Phi-rjan <orjan.roren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: #12360
Proposed Changes
CONTRIBUTING.mdwith detailed guidelines that was previously inREADME.mdREADME.mdand instead link to theCONTRIBUTING.mdpull_request_template.mdChecklist
Before you mark the PR ready for review, please make sure that: