Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update link to the correct sub-section in the Lotus Release Flow #12399

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 16, 2024

Related Issues

#12374

Proposed Changes

Update link when trying to make clean / make all in the releases branch to go directly to the https://github.com/filecoin-project/lotus/blob/master/LOTUS_RELEASE_FLOW.md#why-is-the-releases-branch-deprecated-and-what-are-alternatives.

This was applied in e6b35fe, but got overwritten by a later commit when adding a exit non-zero status code: 9174306.

Checklist

Before you mark the PR ready for review, please make sure that:

chore: update link in releases branch
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Aug 16, 2024
@rjan90 rjan90 requested a review from BigLep August 16, 2024 09:42
@rjan90
Copy link
Contributor Author

rjan90 commented Aug 16, 2024

I have therefore temporarily unlocked the releases branch: https://github.com/filecoin-project/lotus/settings/branch_protection_rules/22005102, as this was locked yesterday as part of #12374 (comment) so that this change can land.

I will lock the branch again, once this PR has been merged.

@rjan90 rjan90 marked this pull request as ready for review August 16, 2024 15:44
@rjan90 rjan90 merged commit 70a94ec into releases Aug 16, 2024
2 checks passed
@rjan90 rjan90 deleted the phi/update-link branch August 16, 2024 15:45
@rjan90
Copy link
Contributor Author

rjan90 commented Aug 16, 2024

I have now locked the releases branch again:

Screenshot 2024-08-16 at 17 45 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants