Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): don't PR or changelog check for draft PRs #12405

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 19, 2024

I was just noticing in #12388 how unnecessary the GHA spam is for a Draft, so this should prevent that until you mark as ready-for-review, I think.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving.

.github/workflows/pr-title-check.yml Outdated Show resolved Hide resolved
@rvagg
Copy link
Member Author

rvagg commented Aug 19, 2024

This is still running the PR check, is that because of pull_request_target?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigLep
Copy link
Member

BigLep commented Aug 19, 2024

This is still running the PR check, is that because of pull_request_target?

I'm not quite following. @rjan90 added pull_request_target so it runs when a contributor opens a PR from a fork.

I think the reason you keep getting alerted about this is because of the syncrhonize event (and that its removal hasn't been merged yet).

(I'm no expert here though...)

@rvagg
Copy link
Member Author

rvagg commented Aug 19, 2024

My point being - I intentionally broke both rules here, no changelog and bad PR title, and it's a draft. But it's complaining about the PR title being wrong, and not the changelog. My expectation is that because I'm modifying the action itself that it would run my edits, but I'm wondering if pull_request_target means it runs the original action from master rather than my branch, while pull_request is running the version off my branch.

@rjan90
Copy link
Contributor

rjan90 commented Aug 19, 2024

This is still running the PR check, is that because of pull_request_target?

From my search online, it does seem that pull_request_target runs in the context of the base repository and not your feature branch, which is why it is complaining that the PR title is being wrong.

@rvagg rvagg changed the title [WIP] fix(ci): don't PR or changelog check for draft PRs fix(ci): don't PR or changelog check for draft PRs Aug 19, 2024
@github-actions github-actions bot dismissed their stale review August 19, 2024 07:24

PR title now matches the required format.

@rvagg rvagg marked this pull request as ready for review August 19, 2024 07:25
@rvagg rvagg merged commit 517c7ae into master Aug 19, 2024
84 of 85 checks passed
@rvagg rvagg deleted the rvagg/less-noisy branch August 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants