-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): don't PR or changelog check for draft PRs #12405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving.
This is still running the PR check, is that because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
I'm not quite following. @rjan90 added pull_request_target so it runs when a contributor opens a PR from a fork. I think the reason you keep getting alerted about this is because of the (I'm no expert here though...) |
My point being - I intentionally broke both rules here, no changelog and bad PR title, and it's a draft. But it's complaining about the PR title being wrong, and not the changelog. My expectation is that because I'm modifying the action itself that it would run my edits, but I'm wondering if |
From my search online, it does seem that |
PR title now matches the required format.
I was just noticing in #12388 how unnecessary the GHA spam is for a Draft, so this should prevent that until you mark as ready-for-review, I think.